-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#64] implement copy paste protection #240
Closed
YuriRomanowski
wants to merge
8
commits into
YuriRomanowski/#64-refactor-markdown-scanner
from
YuriRomanowski/#64-implement-copy-paste-protection
Closed
[#64] implement copy paste protection #240
YuriRomanowski
wants to merge
8
commits into
YuriRomanowski/#64-refactor-markdown-scanner
from
YuriRomanowski/#64-implement-copy-paste-protection
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Currently xrefcheck is not able to detect possibly bad copy-pastes, when some links are referring the same file, but from the link name it seems that one of that links should refer other file. Solution: Implement check, add support for related annotations for `.md` files, add corresponding settings to the config.
YuriRomanowski
changed the title
Yuri romanowski/#64 implement copy paste protection
[#64] implement copy paste protection
Dec 14, 2022
13 tasks
Remove extra parameters in md scanner
And let's assume that the annotations handling PR will depend on the core PR (will have all the commits from the core PR + commits for annotations handling), so that we could have a working part of the functionality after merging the first PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Currently xrefcheck is not able to detect possibly bad copy-pastes, when some links are referring the same file, but from the link name it seems that one of that links should refer other file.
Solution: Implement check, add support for related annotations for
.md
files, add corresponding settings to the config.Related issue(s)
Fixes #64
✅ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)
✓ Release Checklist
package.yaml
.under the "Unreleased" section to a new section for this release version.
vX.Y.Z
.xrefcheck-action
.