[#197] Dependent RepoInfo keys example #243
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: During the implementation of issue #197, we though about how we could customize the way filepaths are searched within the repository data in an efficient way, depending on if filepaths are case-insensitive or not. Solution: We implemented a GADT with its polymorphic parameter, corresponding to Map keys, hidden under an existentially quantified type. Although we end up not requiring this, we separate the essence of the idea to a commit in a separate branch, so it can be reviewed in the future.
|
I believe these changes may be handy if in the future we implement different scanners. As different languages may use different filepath formats when referring to the surrounding files, and these formats may have different comparison rules. I suggested few changes to this PR in this thread. We have to thoroughly think about use cases again and decide how much sense all this have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: During the implementation of issue #197, we though about how we could customize the way filepaths are searched within the repository data in an efficient way, depending on whether filepaths are case-insensitive or not.
Solution: We implemented a GADT with its polymorphic parameter, corresponding to Map keys, hidden under an existentially quantified type. Although we end up not requiring this, we separate the essence of the idea to a commit in a separate branch, so it can be reviewed in the future.
Related issue(s)
Relates #197
✅ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
of Public Contracts policy.
and
Stylistic guide (mandatory)