WIP: Bump Stackage to LTS-22.32 #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
1. Running `nix develop` in the project root does not provide a
development environment of any sort, as evidenced by:
ghc-pkg list
printing only boot libraries.
2. Tests can fail with this error:
xrefcheck-tests: Network.Socket.bind: resource busy (Address already in use)
due to a potential conflict with an already running application.
Solution:
1. flake.nix: inherit devShells
2. tests: configurable mock server port
With these changes I've been able to build the project and run its tests
as follows:
nix shell nixpkgs#haskellPackages.hpack nixpkgs#cabal-install
nix develop -c $SHELL
hpack
vsftpd \
-orun_as_launching_user=yes \
-olisten_port=2221 \
-olisten=yes \
-oftp_username=$(whoami) \
-oanon_root=./ftp-tests/ftp_root \
-opasv_min_port=2222 \
-ohide_file='{.*}' \
-odeny_file='{.*}' \
-oseccomp_sandbox=no \
-olog_ftp_protocol=yes \
-oxferlog_enable=yes \
-ovsftpd_log_file=./ftp.log &
cabal test ftp-tests --test-options="--ftp-host ftp://127.0.0.1:2221"
cabal test xrefcheck-tests --test-options="--mock-server-port 3001"
Problem: we take nyan-interpolation from GitHub, which is harder to manage than if we take it from Hackage. Fortunately, the latest version is now available and suits us. Solution: specify Hackage version of nyan-interpoation[-core] in extra-deps.
Problem: this is a new warning which wants us to provide an explicit kind signature for each type we define. It sounds too verbose to do. Solution: disable this warning.
Problem: retryAfterInfo doesn't compile because the type of readMaybe got more polymorphic in Universum. Solution: specify explicitly that the argument is Text. N.B. In the previous version it was String (due to the old type of readMaybe), but Text is generally preferable, so we're changing it.
Problem: some lens-related things that we use got deprecated in Universum. Solution: do not use them, import them from Control.Lens instead.
…etty Problem: build failure with newer versions of optparse-applicative Module ‘Options.Applicative.Help.Pretty’ does not export ‘displayS’ Module ‘Options.Applicative.Help.Pretty’ does not export ‘renderPretty’ Module ‘Options.Applicative.Help.Pretty’ does not export ‘text’ Solution: stop using functions that have been removed.
Problem: Cross-compilation to windows is broken. Solution: Build 'bitvec' without 'simd' flag
[Note]: Skip this check by adding Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Here to see the CI output.