Close Issue #8 and #12 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2018 16:53
SchedulePage is working for read only with mock data SideBar is working to nav between days TeamPage have a new look and feel NavLinkItems now are mark as selected if your are in '/team/somthing' or '/schedule/something' TeamMember colors is randomly generate, this will be changed soon
DayBlocks show a tiny setBlocks, with mock data for now SchedulePage show messsege when the user hasnt committed any setblock Some functions was renamed to better understand its functionality
otech47
requested changes
Jan 2, 2019
added 4 commits
January 2, 2019 12:34
Fixed color for circle in the ScheduleHeader Action to fech a teamMember by ID was added Now Redux managge the CurrentTeamMember and the SelectedDay GoToSchedule was moved to SideBar Similar Routes have diferents key to make re-mounte when navigate to this extencions Several unused constructors were removed
Not used prop and better declaration of currentTeamMember Minor feature: Since there is a delay in the response of the API, a simple loading componentt is added
otech47
approved these changes
Jan 3, 2019
|
|
||
| if (match.params.dayOfWeek) { | ||
| renderIfItReady() { |
There was a problem hiding this comment.
I think there's a cleaner way to implement loaders I'll have to dig it up from an old repo, but we can revisit this when we are closer to a stable release it's fine as is 👍
| </div> | ||
| <Flex | ||
| row | ||
| flexDirection='horizontal' |
There was a problem hiding this comment.
I don't believe this syntax is necessary for Flex, the row prop should do the trick. Tracking this in #22 for future cleanup since I'd like to just merge this PR and leave these non-critical items for release prep
This was referenced Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SchedulePage is working for read only, with mock data for now
SchedulePage show messsege when the user hasnt committed any setblock
SideBar is working to nav between days
DayBlocks show a tiny setBlocks, with mock data for now
NavLinkItems now are mark as selected if your are in '/team/somthing' or '/schedule/something'
TeamMember colors is randomly generate, this will be changed soon
TeamPage have a new look and feel
Some functions was renamed to better understand its functionality