RFC: fixes python3.10 build of python module - changes to string length in arg parsing #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fine for used string length types
volca02
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://python.readthedocs.io/en/stable/c-api/arg.html#strings-and-buffers
https://bugs.python.org/issue36381
Recent changes to this made python3.10 build of the python module always fail with non-descriptive error (due to error masking in the argument parsing in ServerProxy constructor).
I'd love to version-guard these changes but for the love of me can't find the version which introduced Py_ssize_t as the valid type to use in these situations. So making this a RFC...