Add uninit read methods and switch to _ex when possible #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream crates like
tokio-opensslandhyper-opensslcurrently create possibly-uninitialized slices to feed toSslStream::readwhich is not formally sound. Since std'sReadBuftype isn't yet stable, this PR adds methods that take&mut [MaybeUninit<u8>]slices instead, and provide guarantees about the state after the call in documentation.I also switched over to the
_exvariants of the core OpenSSL IO functions where possible since it avoids issues around ambiguous handling of empty buffers and int-sized length parameters.