Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve install v2 #36

Merged
merged 1 commit into from
Oct 4, 2024
Merged

improve install v2 #36

merged 1 commit into from
Oct 4, 2024

Conversation

coffinsfcompute
Copy link
Contributor

@coffinsfcompute coffinsfcompute commented Oct 4, 2024 •
edited
Loading

Same as v1 but without the mv to mv -T change. I guess that shellcheck didn't catch that issue. I tested it this time on an AWS macOS machine and it seemed to work.

Flaque
Flaque approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@Flaque Flaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@coffinsfcompute coffinsfcompute merged commit f70c492 into main Oct 4, 2024
1 check passed
@coffinsfcompute coffinsfcompute deleted the coffin/improve_installer_v2 branch October 4, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flaque Flaque Flaque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coffinsfcompute @Flaque