fix(linux.usb): memory leak on non-usb udev events (eclipse-kura#5130)

* fix(linux.usb): memory leak on non-usb udev events Signed-off-by: Marcello Martina <[email protected]> * build: added compiled libraries Signed-off-by: Marcello Martina <[email protected]> --------- Signed-off-by: Marcello Martina <[email protected]>
sfiorani · Feb 19, 2024 · 5d3cfc1 · 5d3cfc1
1 parent 538fddc
commit 5d3cfc1
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/kura/org.eclipse.kura.linux.usb.aarch64/lib/linux/libEurotechLinuxUdev.so b/kura/org.eclipse.kura.linux.usb.aarch64/lib/linux/libEurotechLinuxUdev.so
diff --git a/kura/org.eclipse.kura.linux.usb.armv6hf/lib/linux/libEurotechLinuxUdev.so b/kura/org.eclipse.kura.linux.usb.armv6hf/lib/linux/libEurotechLinuxUdev.so
diff --git a/kura/org.eclipse.kura.linux.usb.x86_64/lib/linux/libEurotechLinuxUdev.so b/kura/org.eclipse.kura.linux.usb.x86_64/lib/linux/libEurotechLinuxUdev.so
diff --git a/kura/org.eclipse.kura.linux.usb/src/main/c/udev/LinuxUdev.c b/kura/org.eclipse.kura.linux.usb/src/main/c/udev/LinuxUdev.c
@@ -413,14 +413,14 @@ JNIEXPORT void JNICALL Java_org_eclipse_kura_linux_usb_LinuxUdevNative_nativeHot
 							(*env)->CallVoidMethod(env, linuxUdevNative, LinuxUdevNativeCallback, eventType, UsbDeviceObject);
 						}
 					}
-					udev_device_unref(dev);
 				}
-			}
-			else {
+				udev_device_unref(dev);
+			} else {
 				printf("No Device from receive_device(). An error occured.\n");
 			}
 		}
 		usleep(250*1000);
 	}
 
+	udev_unref(udev);
 }