Remove tidyr::spread()
#552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
commented
Jun 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #552 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1179 1183 +4
=========================================
+ Hits 1179 1183 +4
|
9 tasks
|
Excellent! Thank you for commenting the most complex section. And nice job catching the instance of "spread" that is in a comment, not code 😁 |
|
BTW did the auto-linter run catch the whitespaces that prompted your last commit? |
|
Hi, sfirke, it did, in the sense that I get a notification that the style action didn't pass. See #549 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing mentions of the superseded tidyr functions.
Related Issue
Addresses #549