Minimal argument checking review #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts instead of class(x) %in%
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1184 1180 -4
=========================================
- Hits 1184 1180 -4
|
olivroy
commented
Sep 12, 2023
|
@billdenney in case you have time to look at this PR! it is fairly minimal and straightforward! |
|
This looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standardize argument checking with
rlang::arg_match0()+ use inherits instead of class(x) %in%Related Issue
Addresses #549
Example
See updates in tests, but this just uses https://rlang.r-lib.org/reference/arg_match.html + inherits in some places.