Adds a basic example of std::accumulate. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bejado
reviewed
Sep 22, 2016
| sum_numbers(Collection const& collection) | ||
| { | ||
| using ReturnType = typename Collection::value_type; | ||
| return std::accumulate(std::begin(collection), std::end(collection), static_cast<ReturnType>(0)); |
There was a problem hiding this comment.
Just curious, why use std::begin and std::end instead of collection.begin() and collection.end()?
There was a problem hiding this comment.
Well, it's a generic free function that will call what you expect without any overload (for any decent compiler). It also support arrays, so you can call sum_numbers on an array as well. And of course you can call it with any non-STL container for which an appropriate overload of the functions has been created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should take care of #62.