Merge pull request #441 from scorpioborn/refactor/disable-txs

Refactor / Disable all modules deprecated txs

.github/workflows/codeql.yml

@@ -20,7 +20,7 @@ on:
   schedule:
     - cron: '26 6 * * 2'
 env:
-  GO_VERSION: 1.22
+  GO_VERSION: 1.23
 
 jobs:
   analyze:

.github/workflows/lint.yml

@@ -6,7 +6,7 @@ on:
       - master
 
 env:
-  GO_VERSION: '1.22'
+  GO_VERSION: '1.23'
 
 jobs:
   golangci:

.github/workflows/test.yml

@@ -15,7 +15,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: 1.23
       - name: Display go version
         run: go version
       - name: install tparse
@@ -42,7 +42,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: 1.23
       - uses: technote-space/get-diff-action@v4
         id: git_diff
         with:
@@ -81,7 +81,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: 1.23
       - uses: actions/checkout@v4
       - name: Create a file with all the pkgs
         run: go list ./... | grep -E -v 'tests/e2e' > pkgs.txt
@@ -116,7 +116,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: 1.23
       - uses: technote-space/get-diff-action@v4
         with:
           PATTERNS: |
@@ -194,7 +194,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
+          go-version: 1.23
       - uses: technote-space/get-diff-action@v4
         with:
           PATTERNS: |

.golangci.yml

@@ -3,7 +3,6 @@ run:
   timeout: 15m
   sort-results: true
   allow-parallel-runners: true
-  exclude-dir: testutil/testdata_pulsar
   concurrency: 4
 
 linters:
@@ -16,7 +15,7 @@ linters:
     - durationcheck
     - errcheck
     - errname
-    - exportloopref
+    - copyloopvar
     - forcetypeassert
     - goconst
     - gofmt
@@ -48,7 +47,16 @@ linters:
     - revive
 
 issues:
-  exclude-rules: []
+  exclude-rules: 
+    - path: (.+)_test.go
+      linters: 
+        - gosec
+    - path: suite.go
+      linters: 
+        - gosec
+    - path: testutil
+      linters: 
+        - gosec
   max-issues-per-linter: 10000
   max-same-issues: 10000
 

Dockerfile

@@ -1,6 +1,6 @@
 # syntax=docker/dockerfile:1
 
-ARG GO_VERSION="1.22"
+ARG GO_VERSION="1.23"
 ARG RUNNER_IMAGE="gcr.io/distroless/static-debian11"
 ARG BUILD_TAGS="netgo,ledger,muslc"
 

Makefile

@@ -115,8 +115,8 @@ endif
 ###############################################################################
 
 check_version:
-ifneq ($(GO_MINOR_VERSION),22)
-	@echo "ERROR: Go version 1.22 is required for this version of SGE."
+ifneq ($(GO_MINOR_VERSION),23)
+	@echo "ERROR: Go version 1.23 is required for this version of SGE."
 	exit 1
 endif
 

README.md

@@ -34,7 +34,7 @@ At launch, the SGE Network will be optimized to deploy an inaugural application:
 
 ## Installation Steps
 >
->Prerequisite: go1.22+ required. [ref](https://golang.org/doc/install)
+>Prerequisite: go1.23+ required. [ref](https://golang.org/doc/install)
 
 Sge could be installed by two ways - downloading binary from releases page or build from source.
 

app/upgrades/v10/consts.go

@@ -6,8 +6,8 @@ import (
 	"github.com/sge-network/sge/app/upgrades"
 )
 
-// UpgradeName defines the on-chain upgrade name for the v1.7.4 upgrade.
-const UpgradeName = "v1.7.4"
+// UpgradeName defines the on-chain upgrade name for the v1.7.5 upgrade.
+const UpgradeName = "v1.7.5"
 
 var Upgrade = upgrades.Upgrade{
 	UpgradeName:          UpgradeName,

app/upgrades/v10/upgrades.go

@@ -13,7 +13,7 @@ func CreateUpgradeHandler(
 	configurator module.Configurator,
 	_ *keepers.AppKeepers,
 ) upgradetypes.UpgradeHandler {
-	return func(ctx sdk.Context, plan upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
+	return func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
 		return mm.RunMigrations(ctx, configurator, fromVM)
 	}
 }

app/upgrades/v9/upgrades.go

@@ -43,12 +43,10 @@ func CreateUpgradeHandler(
 	configurator module.Configurator,
 	k *keepers.AppKeepers,
 ) upgradetypes.UpgradeHandler {
-	return func(ctx sdk.Context, plan upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
+	return func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
 		// https://github.com/cosmos/cosmos-sdk/pull/12363/files
 		// Set param key table for params module migration
 		for _, subspace := range k.ParamsKeeper.GetSubspaces() {
-			subspace := subspace
-
 			var keyTable paramstypes.KeyTable
 			switch subspace.Name() {
 			case authtypes.ModuleName:

cmd/sged/cmd/genaccounts_test.go

@@ -61,7 +61,6 @@ func TestSampleCMD(t *testing.T) {
 			args: []string{},
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			var args []string