Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Validation messages for campaign and reward #292

Merged

Conversation

scorpioborn
Copy link
Contributor

Description


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature/rewards@547d1a7). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                Coverage Diff                 @@
##             feature/rewards     #292   +/-   ##
==================================================
  Coverage                   ?   11.99%           
==================================================
  Files                      ?      343           
  Lines                      ?    43362           
  Branches                   ?        0           
==================================================
  Hits                       ?     5200           
  Misses                     ?    37712           
  Partials                   ?      450           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@3eyedraga 3eyedraga marked this pull request as ready for review November 13, 2023 12:16
@3eyedraga 3eyedraga requested a review from a team as a code owner November 13, 2023 12:16
@3eyedraga 3eyedraga merged commit abbd5a5 into sge-network:feature/rewards Nov 13, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants