Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ Upgrade SDK to v47 #377

Merged
merged 35 commits into from
Mar 28, 2024
Merged

Feature/ Upgrade SDK to v47 #377

merged 35 commits into from
Mar 28, 2024

Conversation

scorpioborn
Copy link
Contributor

Description


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.03147% with 545 lines in your changes are missing coverage. Please review.

Project coverage is 11.48%. Comparing base (977c6da) to head (707cfce).

Files Patch % Lines
x/mint/types/tx.pb.go 1.04% 284 Missing ⚠️
x/orderbook/types/query.pb.go 4.00% 24 Missing ⚠️
x/reward/types/query.pb.go 5.88% 16 Missing ⚠️
x/bet/types/query.pb.go 6.66% 14 Missing ⚠️
cmd/sged/cmd/root.go 13.33% 12 Missing and 1 partial ⚠️
x/subaccount/types/tx.pb.go 7.69% 12 Missing ⚠️
x/house/types/query.pb.go 9.09% 10 Missing ⚠️
x/mint/types/query.pb.go 9.09% 10 Missing ⚠️
x/bet/types/bet.pb.go 11.11% 8 Missing ⚠️
x/market/types/query.pb.go 11.11% 8 Missing ⚠️
... and 64 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/v1.8.x     #377      +/-   ##
==================================================
- Coverage           11.60%   11.48%   -0.13%     
==================================================
  Files                 351      352       +1     
  Lines               45689    45981     +292     
==================================================
- Hits                 5304     5282      -22     
- Misses              39905    40222     +317     
+ Partials              480      477       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scorpioborn scorpioborn marked this pull request as ready for review March 28, 2024 08:22
@scorpioborn scorpioborn requested review from 3eyedraga and a team as code owners March 28, 2024 08:22
@3eyedraga 3eyedraga merged commit e7be41d into release/v1.8.x Mar 28, 2024
18 checks passed
@3eyedraga 3eyedraga deleted the feature/upgrade-47 branch March 28, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants