Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / Move campaign percentage to separate field #387

Conversation

scorpioborn
Copy link
Contributor

@scorpioborn scorpioborn commented Apr 17, 2024

Description

Define new properties for reward amount and include percentage.


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • Define Main account percentage
  • Define Subaccount percentage
  • Validate percentages

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the C:CLI label Apr 17, 2024
@scorpioborn scorpioborn changed the title Fix / Move campaign percentage to separate field Refactor / Move campaign percentage to separate field Apr 17, 2024
@scorpioborn scorpioborn marked this pull request as ready for review April 18, 2024 06:37
@scorpioborn scorpioborn requested review from 3eyedraga and a team as code owners April 18, 2024 06:37
@scorpioborn scorpioborn changed the base branch from master to release/v1.6.1 April 18, 2024 07:29
@scorpioborn scorpioborn merged commit 46252d2 into sge-network:release/v1.6.1 Apr 18, 2024
24 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants