Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests using Zarr Python v3 #1277

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Run tests using Zarr Python v3 #1277

merged 1 commit into from
Nov 5, 2024

Conversation

tomwhite
Copy link
Collaborator

@tomwhite tomwhite commented Nov 4, 2024 •
edited
Loading

tomwhite
tomwhite commented Nov 4, 2024
View reviewed changes
sgkit/io/dataset.py


def save_dataset(
ds: Dataset,
store: Union[PathType, MutableMapping[str, bytes]],
storage_options: Optional[Dict[str, str]] = None,
auto_rechunk: Optional[bool] = None,
zarr_format: int = 2,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we're still using version 2 of the Zarr file format.

@tomwhite tomwhite marked this pull request as draft November 4, 2024 15:02
@tomwhite
Copy link
Collaborator Author

tomwhite commented Nov 4, 2024

This was more straightforward now that the VCF code has been moved to bio2zarr.

@tomwhite tomwhite marked this pull request as ready for review November 4, 2024 16:11
jeromekelleher
jeromekelleher approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tomwhite tomwhite merged commit b703e08 into sgkit-dev:main Nov 5, 2024
10 checks passed
@tomwhite tomwhite deleted the zarr-python-v3 branch November 5, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromekelleher jeromekelleher jeromekelleher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests against Zarr 3
2 participants
@tomwhite @jeromekelleher