Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/translations and ux improvements #53

Merged
merged 5 commits into from
Oct 8, 2023

Conversation

sgobotta
Copy link
Owner

@sgobotta sgobotta commented Oct 8, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Add a custom tailwind media query
  • Add some reusable styles for the checkout floating button
  • Update title font size
  • Fix a few translations
  • Update checkout font sizes for different screens

No related issue

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

None of the above. Just UI/UX improvements

Checklist

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build c1e21e93d9ebfb1cc0e11cc9b4fadd6f0e887d62-PR-53

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 60.042%

Files with Coverage Reduction New Missed Lines %
//lib/ex_commerce_web/live/checkout_live/components/cart_component.ex 6 0.0%
Totals Coverage Status
Change from base Build ee021e9ae3c13d6867fd97f6df1e09fc1ee426ba: 0.0%
Covered Lines: 1136
Relevant Lines: 1892

💛 - Coveralls

@sgobotta sgobotta merged commit 37cd7d9 into dev Oct 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants