Make navigation bar in charts example sticky #4879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sokhuong-uon is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
shadcn
requested changes
Sep 23, 2024
There was a problem hiding this comment.
@sokhuong-uon Thanks for taking this one. I found two issues:
- the active state is not updating on scroll.
- it breaks the layout on mobile.
Any change you can take a look?
shadcn
added
the
postpone: more info or changes requested
|
will update. |
|
I've made some changes:
please have a look. shadcn-website-update.mp4 |
sokhuong-uon
force-pushed
the
chore/sticky-charts-nav
branch
from
f279f8f
to
fae1b52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scroll to a new section, the active link won't update. However, I think this update provides a better experience for navigating examples.
