refactor: change error handling to be strongly-typed #1834
Merged
+130
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unsure if this is a breaking change, this is modifying the signatures of |
|
LGTM. Please add doc comments for structs, methods and the mod itself. |
|
And what's the actual use-case of the error type? Do you actually use it as a library? |
|
Done. The error type is not intended to be used outside of the code I've modified. I've changed the package visibility of mod error to package-local. |
|
@ClaytonKnittel Please fix windows build. |
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! New contributor to this project here.
This PR refactors error handling in the local/manager/server binaries, resulting in a net reduction of 26 lines of code.