Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer_vulkan: Don't crash if Depth Format is not recognized #2032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

renderer_vulkan: Don't crash if Depth Format is not recognized #2032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/video_core/renderer_vulkan/liverpool_to_vk.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,17 @@ vk::ClearValue ColorBufferClearValue(const AmdGpu::Liverpool::ColorBuffer& color

vk::SampleCountFlagBits NumSamples(u32 num_samples, vk::SampleCountFlags supported_flags);

static inline vk::Format PromoteFormatToDepth(vk::Format fmt) {
if (fmt == vk::Format::eR32Sfloat) {
static vk::Format PromoteFormatToDepth(vk::Format fmt) {
switch (fmt) {
case vk::Format::eR32Sfloat:
return vk::Format::eD32Sfloat;
} else if (fmt == vk::Format::eR16Unorm) {
case vk::Format::eR16Unorm:
return vk::Format::eD16Unorm;
default:
LOG_ERROR(Render_Vulkan, "Unexpected Depth Format {}", vk::to_string(fmt));
break;
}
UNREACHABLE();
return fmt;
}

} // namespace Vulkan::LiverpoolToVK
Loading