Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of post processing filter in config #2136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ngoquang2708
Copy link
Contributor

No description provided.

@ngoquang2708 ngoquang2708 marked this pull request as draft January 12, 2025 13:12
@ngoquang2708 ngoquang2708 marked this pull request as ready for review January 12, 2025 13:39
@Foul-Tarnished
Copy link

Foul-Tarnished commented Jan 13, 2025

Great!

Could you please add bicubic, lanczos and other asked in #1303 ? 🙏

I imagine "linear" is bilinear ?

GUI for another PR ?
Would be cool if we could choose one filter used when downscaling and another when upscaling.
Like in Cemu
(Would need to check the internal resolution compared to the window actual resolution and use the right filter accordingly)

@ngoquang2708
Copy link
Contributor Author

This PR only allow changing of simple Vulkan filters. I don't know about those custom filters.

@Foul-Tarnished
Copy link

I see

I found this but it seems ratger complex to add
https://github.com/DTolm/VkFFT
https://github.com/DTolm/VkResample

@ngoquang2708 ngoquang2708 marked this pull request as draft January 14, 2025 06:12
@ngoquang2708
Copy link
Contributor Author

Added setting dialog GUI from @rainmakerv3.

@ngoquang2708 ngoquang2708 marked this pull request as ready for review January 14, 2025 07:32
diegolix29 added a commit to diegolix29/shadPS4 that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants