Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show info header only on first command #114

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Conversation

ahangarha
Copy link
Contributor


Closes #111

lib/cpl.rb Outdated Show resolved Hide resolved
lib/cpl.rb Outdated Show resolved Hide resolved
@justin808 justin808 marked this pull request as draft November 25, 2023 03:37
@ahangarha
Copy link
Contributor Author

ahangarha commented Nov 25, 2023

In b38664f, I used class variable because I couldn't implement the solution using a class instance variable.

In 16a829f, I used class instance variable but with a cost of exposing show_info_header as public interface and calling it with Cpl::Cli.show_info_header

@ahangarha ahangarha marked this pull request as ready for review November 25, 2023 11:25
lib/cpl.rb Outdated Show resolved Hide resolved
lib/cpl.rb Show resolved Hide resolved
Copy link
Collaborator

@rafaelgomesxyz rafaelgomesxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one thing I missed about initializing the variable, but no need for re-review.

lib/cpl.rb Outdated Show resolved Hide resolved
lib/cpl.rb Show resolved Hide resolved
@justin808
Copy link
Member

LGTM

@justin808 justin808 merged commit 43ef1be into main Dec 1, 2023
9 checks passed
@justin808 justin808 deleted the show-info-header-only-once branch December 1, 2023 20:44
@justin808
Copy link
Member

@ahangarha clear on why this is better?

@ahangarha
Copy link
Contributor Author

clear on why this is better?

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show info header only once
3 participants