Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow build-image command to accept extra options and pass them to docker build #126

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Allow build-image command to accept extra options and pass them to docker build #126

merged 3 commits into from
Jan 12, 2024

Conversation

rafaelgomesxyz
Copy link
Collaborator

@rafaelgomesxyz rafaelgomesxyz commented Jan 12, 2024 •
edited
Loading

Fixes #125

Previously, the command below would raise an error because cache is not defined in the OPTIONS for the build-image command.

cpl build-image -a app --cache /tmp/cache

Now the extra non-defined options (in this case --cache /tmp/cache) will be accepted and passed to docker build instead.

@rafaelgomesxyz rafaelgomesxyz self-assigned this Jan 12, 2024
@rafaelgomesxyz rafaelgomesxyz merged commit 6894b26 into main Jan 12, 2024
9 checks passed
@rafaelgomesxyz rafaelgomesxyz deleted the build-image-extra-options branch January 12, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafaelgomesxyz rafaelgomesxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build-image command should accept extra options and pass them to docker build
1 participant
@rafaelgomesxyz