Allow specifying upstream for copy-image-from-upstream command through CPLN_UPSTREAM env var
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rafaelgomesxyz
force-pushed
the
copy-image-from-upstream-org-precedence
branch
from
1d03eac to
329808a
Compare
rafaelgomesxyz
force-pushed
the
copy-image-from-upstream-env-var
branch
from
3bff36b to
0089299
Compare
Merged
Base automatically changed from
copy-image-from-upstream-org-precedence
to
main
January 22, 2024 04:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: On top of #137
In the
copy-image-from-upstreamcommand, since we allow specifying the upstream org through theCPLN_ORG_UPSTREAMenv var, we should also allow specifying the upstream app through theCPLN_UPSTREAMenv var.This PR adds that.