-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terraform generate command #220
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
end | ||
|
||
def to_tf | ||
block :terraform do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example of DSL usage so that we can describe Terraform config files via block
and argument
methods
Do you think that this is the best approach for describing TF config files? Or should we use Terraform JSON format? Or maybe HEREDOC will be enough? 🤔
Terraform::Config::RequiredProvider#to_tf
produces string (see https://github.com/shakacode/control-plane-flow/pull/220/files#diff-5f77765503204dee0fbde47d7c63260b3d4373530f61680e77f4b13200963b2fR27):
terraform {
required_providers {
cpln = {
source = "controlplane-com/cpln"
version = "~> 1.0"
}
}
}
Closing this PR since terraform features will be implemented incrementally in separate PRs |
What does this PR do?
This PR introduces new subcommand
terraform
forcpflow
CLI tool. Currently this subcommand has only 1 command -generate
Important note
This is Draft PR, the main purpose of which is to get opinions on Terraform DSL feature implementation