Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show org and app on every command #94

Merged
merged 11 commits into from
Nov 14, 2023
Merged

Show org and app on every command #94

merged 11 commits into from
Nov 14, 2023

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Nov 2, 2023 •
edited
Loading

A PR for showing ORG and APP in every command except certain ones.

Sample:

~ CPLN_ORG=my-org-name CPLN_APP=tutorial-app cpl apply-template redis
ORG: my-org-name
APP: tutorial-app
...

@ahangarha ahangarha self-assigned this Nov 3, 2023
@ahangarha ahangarha changed the title WIP - Show org and app on every command Show org and app on every command Nov 3, 2023
@ahangarha ahangarha marked this pull request as ready for review November 3, 2023 18:33
@ahangarha
Copy link
Contributor Author

Should we separate this "info header" from other logs using some sort of divider?

rafaelgomesxyz
rafaelgomesxyz requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@rafaelgomesxyz rafaelgomesxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not add it to the env and latest-image commands, as their output might be used directly.

And we also need to consider the ps command, as it outputs a list of replicas, so if the output is used directly and we add a header it could break things. Thoughts?

lib/command/base.rb Outdated Show resolved Hide resolved
lib/command/info.rb Show resolved Hide resolved
lib/cpl.rb Outdated Show resolved Hide resolved
lib/cpl.rb Outdated Show resolved Hide resolved
lib/cpl.rb Show resolved Hide resolved
rafaelgomesxyz
rafaelgomesxyz approved these changes Nov 14, 2023
View reviewed changes
lib/core/config.rb Show resolved Hide resolved
@ahangarha ahangarha merged commit 46e4569 into main Nov 14, 2023
9 checks passed
@ahangarha ahangarha deleted the show-org-and-app-on-every-command branch November 14, 2023 11:51
This was referenced Nov 14, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelgomesxyz rafaelgomesxyz rafaelgomesxyz approved these changes

Assignees

@ahangarha ahangarha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahangarha @rafaelgomesxyz