Skip to content

Commit

Permalink
Disable Windows build on CI and add note to README
Browse files Browse the repository at this point in the history
  • Loading branch information
alex35mil committed Jun 18, 2024
1 parent ab84ed5 commit b0b18ab
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, macOS-latest, windows-latest ]
os: [ ubuntu-latest, macOS-latest ] # windows build is broken, see the note in README
steps:
- name: Checkout sources
uses: actions/checkout@v2
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ See [docs.rs/steward](https://docs.rs/steward).
See [`examples`](./examples).

## Limitations
### Windows
Apparently, Windows build is broken on recent versions of Rust due to [`winapi`](https://github.com/retep998/winapi-rs) being unmaintained. We need to migrate to [`windows-rs`](https://github.com/microsoft/windows-rs), but I don't know anything about Windows, so help is very welcome!

### Async runtimes
Tokio only.

Expand Down
6 changes: 6 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@
//! ```
//!
//! ## Limitations
//! ### Windows
//! Apparently, Windows build is broken on recent versions of Rust due to
//! [`winapi`](https://github.com/retep998/winapi-rs) being unmaintained.
//! We need to migrate to [`windows-rs`](https://github.com/microsoft/windows-rs),
//! but I don't know anything about Windows, so help is very welcome!
//!
//! ### Async runtimes
//! Tokio only.
Expand Down

0 comments on commit b0b18ab

Please sign in to comment.