Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csharp_宋子豪_无25 #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 79 additions & 35 deletions hw1/hw1/Program.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System.Reflection.Metadata.Ecma335;

namespace Homework1
{
Expand All @@ -11,17 +11,17 @@ public static void Main(string[] args) // 该程序用于Debug
{
try
{
progress.Start(i*((i%2==0)?1:-1));
progress.Start(i * ((i % 2 == 0) ? 1 : -1));
}
catch (Exception e)
{
Console.WriteLine(e.Message);
}
if (i % 3 != 0)
{
progress.Add(i-1);
progress.Add(i - 1);
}
else progress.Sub(i-1);
else progress.Sub(i - 1);

if (i == 6 || i == 7)
{
Expand All @@ -43,8 +43,8 @@ public interface IProgress
/// 如果之前进度条已经加载完成,则将进度清零开始下一次加载,返回true,但如果requiredProgress<0,应当报错
/// 如果之前进度条尚未加载完成,返回false
/// </summary>
public bool Start(int requiredProgress);
public bool Start(int requiredProgress);

public void Add(int addProgress); //增加addProgress的进度
public void Sub(int subProgress); //减少subProgress的进度
public void Double(); //进度翻倍
Expand All @@ -57,36 +57,80 @@ public interface IProgress

public class Progress : IProgress
{
// 一个进度条
public static int num = 0;
public Progress()
{
num++;
}
public int Num
{
get
{
return num;
}
}
public int RequiredProgress { get; set; }
public int FinishedProgress { get; set; }
Copy link
Owner

@shangfengh shangfengh Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本意是希望能在set访问器里限制 FinishedProgress的范围的,特别是多人研发时能确保安全。
但是事实上即便设置了属性,类内依旧可以访问字段,属性更像对类外操作的要求。
所以不开放set访问器(要保证赋值总是合法的,不能让外界无条件修改),只在方法内进行范围限制也合理
这里应当考虑private set

public void Add(int addProgress)
{
FinishedProgress += addProgress;
if (FinishedProgress > RequiredProgress) { FinishedProgress = RequiredProgress; }
}
public void Sub(int subProgress)
{
FinishedProgress -= subProgress;
if (FinishedProgress < 0) { FinishedProgress = 0; }
}
public void Double()
{
FinishedProgress *= 2;
if (FinishedProgress > RequiredProgress) { FinishedProgress = RequiredProgress; }
}
public bool Start(int requiredProgress)
{
if (FinishedProgress == RequiredProgress)
{
if (requiredProgress < 0)
throw new Exception("RequiredProgress must be positive");
else
{
RequiredProgress = requiredProgress;
FinishedProgress = 0;
return true;
}
}
return false;
}
public (int FinishedProgress, int RequiredProgress) GetProgress() { return (FinishedProgress, RequiredProgress); }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以直接=>(FinishedProgress, RequiredProgress);

// 只允许修改Progress类中的代码
// 要求实现IProgress中的要求
}

/*
* 输出示例:
RequiredProgress must be positive. (Parameter 'Homework1.Progress')
(0, 0)
(1, 2)
(0, 2)
(2, 2)
RequiredProgress must be positive. (Parameter 'Homework1.Progress')
(2, 2)
(0, 6)
(6, 6)
(7, 8)
(0, 8)
(8, 8)
RequiredProgress must be positive. (Parameter 'Homework1.Progress')
(8, 8)
(0, 12)
(12, 12)
(13, 14)
(0, 14)
(14, 14)
RequiredProgress must be positive. (Parameter 'Homework1.Progress')
(14, 14)
(0, 18)
(18, 18)
(19, 20)
*/
}
/*
* 输出示例:
RequiredProgress must be positive. (Parameter 'Homework1.Progress')
(0, 0)
(1, 2)
(0, 2)
(2, 2)
RequiredProgress must be positive. (Parameter 'Homework1.Progress')
(2, 2)
(0, 6)
(6, 6)
(7, 8)
(0, 8)
(8, 8)
RequiredProgress must be positive. (Parameter 'Homework1.Progress')
(8, 8)
(0, 12)
(12, 12)
(13, 14)
(0, 14)
(14, 14)
RequiredProgress must be positive. (Parameter 'Homework1.Progress')
(14, 14)
(0, 18)
(18, 18)
(19, 20)
*/
}