CSharp_顾朗哲_无21 #19
Open
CSharp_顾朗哲_无21 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangfengh
reviewed
Sep 23, 2023
| bool isAtReady = true; | ||
|
|
||
| public bool Start(long needTime) { | ||
| object lockobject = new object(); |
There was a problem hiding this comment.
锁应当作为字段，否则每次调用方法都是对一个全新的锁进行占用，这毫无意义
| public bool TrySet0() { | ||
| object lockobject = new object(); | ||
| lock (lockobject) { | ||
| if (!isAtReady) { |
| public void Set0() { | ||
| object lockobject = new object(); | ||
| lock (lockobject) { | ||
| finishedTime = 0; |
There was a problem hiding this comment.
finishedTime 的意义是？
isAtReady 应当更新
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.