analog/buttons: make sure analog buttons are forcefully refreshed if …

…requested
shanteacontrols · Dec 2, 2024 · 164beb1 · 164beb1
1 parent 00473f2
commit 164beb1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/firmware/application/io/analog/Analog.cpp b/src/firmware/application/io/analog/Analog.cpp
@@ -100,6 +100,7 @@ void Analog::updateSingle(size_t index, bool forceRefresh)
         {
             analogDescriptor_t descriptor;
             fillAnalogDescriptor(index, descriptor);
+            descriptor.event.forcedRefresh = true;
 
             descriptor.newValue = _lastValue[index];
             descriptor.oldValue = _lastValue[index];

diff --git a/src/firmware/application/io/buttons/Buttons.cpp b/src/firmware/application/io/buttons/Buttons.cpp
@@ -45,8 +45,22 @@ Buttons::Buttons(HWA&      hwa,
                               buttonDescriptor_t descriptor;
                               fillButtonDescriptor(index, descriptor);
 
-                              // event.value in this case contains state information only
-                              processButton(index, event.value, descriptor);
+                              if (!event.forcedRefresh)
+                              {
+                                  // event.value in this case contains state information only
+                                  processButton(index, event.value, descriptor);
+                              }
+                              else
+                              {
+                                  if (descriptor.type == type_t::LATCHING)
+                                  {
+                                      sendMessage(index, latchingState(index), descriptor);
+                                  }
+                                  else
+                                  {
+                                      sendMessage(index, state(index), descriptor);
+                                  }
+                              }
                           });
 
     MIDIDispatcher.listen(messaging::eventType_t::TOUCHSCREEN_BUTTON,