Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metamask: only detectEthereumProvider() once #417

Merged
merged 1 commit into from
Apr 8, 2022
Merged

metamask: only detectEthereumProvider() once #417

merged 1 commit into from
Apr 8, 2022

Conversation

mrnerdhair
Copy link
Contributor

@mrnerdhair mrnerdhair commented Feb 11, 2022 •
edited
Loading

This follows the style from the new hdwallet-xdefi and makes fixing #416 easier.

@vercel
Copy link

vercel bot commented Feb 11, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shapeshift/hdwallet/HouyXQQcSPmPi44Gh7kPSQNteHyP
✅ Preview: https://hdwallet-git-metamask-provider-parameter-shapeshift.vercel.app

@mrnerdhair mrnerdhair force-pushed the metamask-provider-parameter branch from 3f73754 to e615e8f Compare February 11, 2022 22:47
@mrnerdhair mrnerdhair force-pushed the metamask-provider-parameter branch from e615e8f to 6136b5a Compare February 12, 2022 02:38
@mrnerdhair mrnerdhair force-pushed the metamask-provider-parameter branch from 6136b5a to b7001d7 Compare February 12, 2022 02:49
@mrnerdhair mrnerdhair requested review from pastaghost and asamere March 4, 2022 21:28
@mrnerdhair mrnerdhair added this to the Low Priority milestone Mar 5, 2022
mrnerdhair
mrnerdhair commented Mar 8, 2022
View reviewed changes
integration/src/integration.ts Outdated Show resolved Hide resolved
integration/src/wallets/__mocks__/@metamask/detect-provider.ts Outdated Show resolved Hide resolved
integration/src/wallets/metamask.ts Outdated Show resolved Hide resolved
@mrnerdhair mrnerdhair mentioned this pull request Mar 14, 2022
Open
@mrnerdhair mrnerdhair force-pushed the metamask-provider-parameter branch from 28a2c25 to 471fe2f Compare March 23, 2022 00:41
@mrnerdhair mrnerdhair force-pushed the metamask-provider-parameter branch from 471fe2f to e1fe00c Compare March 23, 2022 01:23
@mrnerdhair mrnerdhair requested a review from pastaghost March 23, 2022 01:23
@mrnerdhair
Copy link
Contributor Author

@cjthompson @pastaghost I've updated the implementation here based on chris's feedback that web's using wallet.initialize(). Also updated #423 to harmonize xdefi with this approach: cad67f9

@mrnerdhair mrnerdhair mentioned this pull request Apr 7, 2022
Merged
@mrnerdhair mrnerdhair force-pushed the metamask-provider-parameter branch from e1fe00c to 6beeb13 Compare April 8, 2022 21:22
@mrnerdhair mrnerdhair merged commit 847c585 into master Apr 8, 2022
@mrnerdhair mrnerdhair removed this from the Low Priority milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjthompson cjthompson cjthompson approved these changes

@asamere asamere Awaiting requested review from asamere

@0xdef1cafe 0xdef1cafe Awaiting requested review from 0xdef1cafe

@pastaghost pastaghost Awaiting requested review from pastaghost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrnerdhair @cjthompson @pastaghost