feat: remove unused type guard typings #550
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@pastaghost Keeping this as a draft waiting for your input here. In the context of our consumptions, the type guards are effectively useless, but now that I'm thinking about it, we might have other projects consuming this and it might bring breaking type changes for them. Happy to close both this and the issue with the rationale that hdwallet is open-source and we shouldn't tie implementations to our own usages. |
|
@pastaghost thoughts on this one re: @gomesalexandre comment? I'm in favour of removing the type guard typings, as these functions aren't actually type guards (beyond their syntax), and so are misleading. |
There was a problem hiding this comment.
I think this PR makes these functions more correct, as they are more utility functions than actual type guards.
Pending thoughts from @pastaghost.
|
I agree with @0xApotheosis on this one - I don't think this is proper use of a user-defined type guard. I'm in favor of removing the type guard returns and have approved the PR. |
|
IMO this doesn't make sense. These type guards suck, but there's no reason to erase the metadata about what they do -- especially if some are still in use. (It wasn't that long ago when we were using supportsETH in web/lib.) I recommend either keeping them or removing them completely, along with the |
|
(For an example of the above, see #435, which was closed at the time due to lack of review bandwidth.) |
Description
This removes the unused type guard (
x is Y) from thesupportsXYZmethodsNote that the
supportsCosmosandsupportsOsmosisones are kept, as they are actually used inchain-adapters.Tried linking in lib and web and this builds/passes type-check.
Issue