feat: keepkey taproot support (ish) #701
Open
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
gomesalexandre
commented
Dec 16, 2024
| @@ -88,7 +94,9 @@ function prepareSignTx( | |||
| newOutput.setOpReturnData(output.opReturnData); | |||
| } else { | |||
| // BTCSignTxOutputSpend | |||
| newOutput.setScriptType(Types.OutputScriptType.PAYTOADDRESS); | |||
| newOutput.setScriptType( | |||
| output.address.startsWith("bc1p") ? PAYTOTAPROOT_PROTOBUF_SCRIPTTYPE : Types.OutputScriptType.PAYTOADDRESS | |||
There was a problem hiding this comment.
Note this is not coming from Types.OutputScriptType but declared manually, see below in this diff.
I did try to install @trezor/protobuf (which @keepkey/device-protocol should be a superset of, but is outdated) and consume those types directly instead of the ones from @keepkey/devices however build was failing with a gazillion of @shapeshiftoss/bitcoinjs-lib build errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"ish", as in we're building a correct payload that KeepKey is unable to understand because of firmware itself not supporting P2TR outputs.
This is more than likely related to https://github.com/keepkey/device-protocol being the source-of-truth for messaging on the device, and said library not being up-to-date with latest
@trezor/protobuf(which@keepkey/device-protocolshould be a superset of, and by extension, the device should understand the latest spec of).Testing
Unfortunately, none. If you really want to test this, put a debugger breakpoint in
newOutputafter thesetScriptType()call (see inline comments) and ensure that the scriptType is 6 i.e P2TR:https://github.com/trezor/trezor-suite/blob/221fe9e7fcd29fc2ef5fa51ca2c22ba6a9369ef6/packages/protobuf/src/messages.ts#L127
Issue
Relates to shapeshift/web#8277