Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network fees at trade confirmation screens as needed separate from quotes #8270

Closed
0xean opened this issue Dec 4, 2024 · 2 comments · Fixed by #8432
Closed

Update network fees at trade confirmation screens as needed separate from quotes #8270

0xean opened this issue Dec 4, 2024 · 2 comments · Fixed by #8432
Assignees

Comments

@0xean
Copy link
Contributor

0xean commented Dec 4, 2024

  • confirmation screen should still allow for network fees to be periodically refreshed
@gomesalexandre
Copy link
Contributor

Reopening as wrong issue closed

@gomesalexandre
Copy link
Contributor

gomesalexandre commented Dec 10, 2024

as a follow up to this ticket we should either then add updates to the quote or if we cannot accomplish this then update the network fees at the least.

@0xean FYI this issue is actually decoupled from 0x permit2 work

#8313 went in yesterday which closes #8271

It did not do any kind of network fees refetch however, since that's the goal of this (8270)

Keeping this one in backlog since it has needs grooming tag, however, do expect one tackles #8270 PR for this issue for the specific case of Li.Fi in the meantime.

Update: here it is! #8326

@gomesalexandre gomesalexandre self-assigned this Dec 10, 2024
@gomesalexandre gomesalexandre moved this from Up next / groomed to Backlog in ShapeShift Dashboard Dec 10, 2024
@gomesalexandre gomesalexandre removed their assignment Dec 17, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Dec 18, 2024
@gomesalexandre gomesalexandre self-assigned this Dec 20, 2024
@gomesalexandre gomesalexandre moved this from Up next / groomed to In progress in ShapeShift Dashboard Dec 23, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants