Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the edge-case for Li.Fi, ensuring that like other swappers, gets a final trade quote with the most up-do-date data (rate/fees).
This improves things twofolds:
Issue (if applicable)
Risk
Medium - if we get this wrong, Li.Fi final trade quote time would show an empty broken state, see testing steps below
Testing
From my testing, 1 FOX.ARB -> ETH.ARB seems to be a good contender, as ZRX/Li.Fi and Enso Li.Fi routes will be present in some quotes list, but not consistently:
Note, you'll have to try to back out to input, then back to final quotes many many times (while having the quote you have spotted as unstable selected) over to ensure we consistently get said route and don't end up with the empty quote bug above
Engineering
exchanges: { allow: [tool] }
Operations
Screenshots (if applicable)
https://jam.dev/c/fc162032-bbff-4c89-927c-259c79686071
https://jam.dev/c/1e1ea531-5961-49b3-b53f-4b8c54eefe09