-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add arbitrum #5337
feat: add arbitrum #5337
Conversation
packages/caip/src/adapters/coingecko/generated/eip155_42161/adapter.json
Outdated
Show resolved
Hide resolved
packages/chain-adapters/src/evm/arbitrum/ArbitrumChainAdapter.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, conceptual stamp pending runtime testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, without an Arbitrum native/asset balance
Asset search
Asset page
Accounts page
Assets page
Chain switch
Tested with frame-injected account
Accounts page
Account page
Asset page
DeFi opportunities - tested against Zapper
Note the asset and underlying asset balances are correct but the position fiat value isn't - unrelated to this PR however.
NFTs
Tested with MM
Description
Add arbitrum support:
TODO:
Support any other swappers with arbitrum support (cow, lifi, one inch)?Update chain adapter and unchained client tests once unchained coinstack is up and runningBump hdwallet once merged and publishedFollow Up:
Pull Request Type
Issue (if applicable)
N/A
Risk
Low
Testing
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
Zrx:
LiFi:
OneInch: