Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arbitrum #5337

Merged
merged 20 commits into from
Oct 9, 2023
Merged

feat: add arbitrum #5337

merged 20 commits into from
Oct 9, 2023

Conversation

kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Sep 21, 2023

Description

Add arbitrum support:

  • Send/Receive
  • Balances/TxHistory
  • Nft Support
  • Swap Support (zrx, oneinch, and lifi)

TODO:

  • Support any other swappers with arbitrum support (cow, lifi, one inch)?
  • Update chain adapter and unchained client tests once unchained coinstack is up and running
  • Bump hdwallet once merged and published

Follow Up:

  • Fiat on-ramps

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

Low

Testing

  • Test send and receive of native assets and tokens
  • Validate correct balances, charts, and transaction history
  • Validate correct nft display
  • Test swapping native -> token, token -> native, token -> token
  • Spot check functionality working on all supported wallets
  • Spot check gas estimations/prices align with what is reported on block explorer

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

image

image

image

image

image

  • Zrx:
    image

  • LiFi:
    image

  • OneInch:
    image

@kaladinlight kaladinlight marked this pull request as ready for review October 4, 2023 17:12
@kaladinlight kaladinlight requested a review from a team as a code owner October 4, 2023 17:12
.env.base Show resolved Hide resolved
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, conceptual stamp pending runtime testing

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, without an Arbitrum native/asset balance

Asset search

image

Asset page

image

Accounts page

image

Assets page

image

Chain switch

image

Tested with frame-injected account

Accounts page

image

Account page

image

Asset page

image

DeFi opportunities - tested against Zapper

image image

Note the asset and underlying asset balances are correct but the position fiat value isn't - unrelated to this PR however.

NFTs

image image

Tested with MM

Tx history

image

Self-send

image image

@kaladinlight kaladinlight merged commit 7eecd8a into develop Oct 9, 2023
3 checks passed
@kaladinlight kaladinlight deleted the add-arbitrum branch October 9, 2023 19:14
@kaladinlight kaladinlight mentioned this pull request Oct 11, 2023
3 tasks
@kaladinlight kaladinlight mentioned this pull request Nov 27, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants