Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plotly interactive chart thing #5375

Merged
merged 22 commits into from
Oct 3, 2023
Merged

feat: plotly interactive chart thing #5375

merged 22 commits into from
Oct 3, 2023

Conversation

0xdef1cafe
Copy link
Collaborator

@0xdef1cafe 0xdef1cafe commented Sep 28, 2023

Description

interactive fee slider chart thing

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #

Risk

low - behind flag, flag currently off, doesn't affect trading, presentational only.

Testing

no testing required - we'll integration test everything once fees are wired in to the trade input

Engineering

Operations

Screenshots (if applicable)

image

@0xdef1cafe 0xdef1cafe force-pushed the plotly branch 2 times, most recently from dbcc9d8 to c38793a Compare September 29, 2023 00:17
@0xdef1cafe 0xdef1cafe marked this pull request as ready for review October 2, 2023 23:37
@0xdef1cafe 0xdef1cafe requested a review from a team as a code owner October 2, 2023 23:37
@woodenfurniture woodenfurniture merged commit 8beb273 into develop Oct 3, 2023
3 checks passed
@woodenfurniture woodenfurniture deleted the plotly branch October 3, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants