Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos, remove unused entries #5428

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Oct 6, 2023

Description

Fix a few typos, remove the mispelled unused entry "reawrds"

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Risk

None

@omahs omahs requested a review from a team as a code owner October 6, 2023 06:32
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for the the PR ser, lets get that unused entry removed, fill in the PR template and get this in 🍻

@omahs omahs changed the title chore: fix typos chore: fix typos, remove unused entries Oct 9, 2023
@omahs
Copy link
Contributor Author

omahs commented Oct 9, 2023

@woodenfurniture Done ser! 🍻

@woodenfurniture woodenfurniture enabled auto-merge (squash) October 9, 2023 23:37
@woodenfurniture woodenfurniture merged commit aa77f59 into shapeshift:develop Oct 9, 2023
@firebomb1
Copy link
Contributor

@woodenfurniture gm, I've only noticed this PR now, it would be better to not alter the translations files manually as they are generated from Gitlocalize (our translation platform) and in the past it caused issues with synchronization.

If coincidentally translators were to work on the same strings that got modified here, the changes they made could potentially get overwritten when we update the repo used for Gitlocalize if we don't notice such PR. So if changes are needed in translations, please inform us in #engineering-translations or in any #global channel, I can include them in our fork in due time and later push them during a weekly sync so we avoid these issues.

Lastly, en/main.json is our source of truth when it comes to Gitlocalize, when you delete a key from the English file it will automatically get deleted in all the translation files, so it shouldn't be necessary to manually delete them in each one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants