Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bsc savers user staking data #5435

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 9, 2023

Description

Makes sure BSC savers references are added everywhere, so that BSC user staking data is properly fetched - it accidentally works on deposit/withdraw currently, as we use <TransactionProvider /> user-data fetching introspecting THOR Tx, but won't fetch the user staking data when importing a wallet.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5415

Risk

None

Testing

  • Have a wallet with a savers BNB active position (can use e.g a diff env for that, or deposit then clear your localForage)
  • Savers user staking data for BNB on BSC is fetched on wallet import, without needing to do a deposit

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

  • Develop
Screenshot 2023-10-09 at 10 24 04
  • This diff
image

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@gomesalexandre gomesalexandre force-pushed the fix_thor_bsc_deposits_state branch from 192f4b1 to 4719c64 Compare October 9, 2023 08:15
@gomesalexandre gomesalexandre marked this pull request as ready for review October 9, 2023 08:50
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 9, 2023 08:50
@gomesalexandre gomesalexandre force-pushed the fix_thor_bsc_deposits_state branch from 9a0c88d to 7a101c1 Compare October 9, 2023 21:12
@kaladinlight kaladinlight merged commit b08b279 into develop Oct 9, 2023
6 checks passed
@kaladinlight kaladinlight deleted the fix_thor_bsc_deposits_state branch October 9, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BNB ThorChain Saver Vault not displaying balance after importing wallet
2 participants