Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lending ui #5437

Merged
merged 30 commits into from
Oct 26, 2023
Merged

feat: lending ui #5437

merged 30 commits into from
Oct 26, 2023

Conversation

reallybeard
Copy link
Contributor

@reallybeard reallybeard commented Oct 9, 2023

Description

  • This adds lending UI
  • Adds a new feature flag

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5363

Risk

No risks

Testing

Engineering

Operations

No testing

Screenshots (if applicable)

@reallybeard reallybeard requested a review from a team as a code owner October 9, 2023 21:13
.env.dev Outdated Show resolved Hide resolved
.env.dev Outdated Show resolved Hide resolved
.env.dev Outdated Show resolved Hide resolved
.env.develop Outdated Show resolved Hide resolved
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, confirmed the view layer looks good, and isn't showing up with the lending flag off

@gomesalexandre gomesalexandre enabled auto-merge (squash) October 26, 2023 09:18
@gomesalexandre gomesalexandre merged commit f1d8083 into develop Oct 26, 2023
3 checks passed
@gomesalexandre gomesalexandre deleted the WEB-5363 branch October 26, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thorchain lending
2 participants