Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lifi bridges final trade quote #8348

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 12, 2024

Description

This PR ensures that we properly populate allowed bridge (as gotten from rate time as [bridge] at rate time), under the bridges allowedlist for Li.Fi, vs. us erroneously doing so under the exchanges umbrella previously.

This means that all bridges were guaranteed to fail at quote time, as bridges and exchanges are two different notions / schemas, and passing one in the other would fail validation upstream.

Issue (if applicable)

closes #8344

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low, small risk of regular trades broken but easily regression testable

Testing

  • When attempting a Li.Fi bridge, you're not getting a blank screen at final quote time
  • Well, there is one ramification to that: you may still get a blank screen at final quote time, but that's an entirely different issue and unrelated to bridges: Blank screen attempting to execute unstable tool on Li.Fi #8347
  • Same-chain Li.Fi swaps are still happy

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

  • Li.Fi Bridges in develop

https://jam.dev/c/d583435a-75b8-4e7d-94a2-99858b1f233f

  • Li.Fi Bridges in this diff

https://jam.dev/c/9c894f4e-ea0f-4a5d-a04f-29d70266c9a8

  • Li.Fi same-chain swaps in this diff

https://jam.dev/c/f39adad4-1bdf-49eb-b5ad-74b2d9161c0a

@gomesalexandre gomesalexandre changed the base branch from develop to release December 12, 2024 09:23
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridge (ARB to Avax) (The success tx hasn't been auto fetched, it was loading infinitely, but doesn't seem related to the TX at all)
https://jam.dev/c/d989d364-67ae-45da-88e9-0c9dd8605f79

Swap
https://jam.dev/c/c713feb5-290f-4f08-a62a-4adfac5ce115

@gomesalexandre gomesalexandre merged commit 27163a0 into release Dec 12, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the fix_lifi_bridges branch December 12, 2024 14:39
0xApotheosis pushed a commit that referenced this pull request Dec 17, 2024
fix: lifi bridges final trade quote (#8348)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank screen attempting to execute bridges on Li.Fi
2 participants