fix: lifi bridges final trade quote #8348
Merged
+37
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that we properly populate allowed bridge (as gotten from rate time as
[bridge]
at rate time), under the bridges allowedlist for Li.Fi, vs. us erroneously doing so under theexchanges
umbrella previously.This means that all bridges were guaranteed to fail at quote time, as bridges and exchanges are two different notions / schemas, and passing one in the other would fail validation upstream.
Issue (if applicable)
closes #8344
Risk
Low, small risk of regular trades broken but easily regression testable
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/d583435a-75b8-4e7d-94a2-99858b1f233f
https://jam.dev/c/9c894f4e-ea0f-4a5d-a04f-29d70266c9a8
https://jam.dev/c/f39adad4-1bdf-49eb-b5ad-74b2d9161c0a