Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: more new swapper tweaks #8437

Merged
merged 4 commits into from
Dec 23, 2024
Merged

chore: more new swapper tweaks #8437

merged 4 commits into from
Dec 23, 2024
+139 −118

Conversation

0xApotheosis
Copy link
Contributor

Description

Adds more improvements to the new swapper:

  1. Refactor and code improvements from review comments in feat: incremental tweaks to new swapper #8408
  2. Update TradeStep vernacular to StepperStep to better disambiguate between the concepts
  3. Fix the error indicator state for inner steps

Issue (if applicable)

Contributes to #8118

Risk

Low

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

Engineering

Quick sanity check of the error state (easy to simulate by blocking connections after trade preview):

Screenshot 2024-12-23 at 15 58 29

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

See above.

@0xApotheosis 0xApotheosis requested a review from a team as a code owner December 23, 2024 05:03
@gomesalexandre gomesalexandre self-requested a review December 23, 2024 12:49
gomesalexandre
gomesalexandre approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check LGTM! Get in ser.

https://jam.dev/c/040af6cc-e703-4df0-b152-a85333571d90

@gomesalexandre gomesalexandre enabled auto-merge (squash) December 23, 2024 15:34
@gomesalexandre gomesalexandre merged commit 8cc5525 into develop Dec 23, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the new-swapper-tweaks-2 branch December 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xApotheosis @gomesalexandre