Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: keystore import #8442

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

wip: keystore import #8442

wants to merge 1 commit into from

Conversation

gomesalexandre
Copy link
Contributor

Description

WIP Companion PR for shapeshift/hdwallet#703 - just very basic PoC on the web side while this is WIP, however, this is already testable e2e.

Note: This won't match the Figma mocks, as these expects the new wallet design/flow is implemented, which it is not (and we don't even have specced yet AFAIK, cc @shapeshift/product).

TODO:

  • make it work
  • feature flag for all this, since the flow is most likely to change, this is just a working PR, but with temporary PoC flow.
  • make it clean
  • make it pretty
  • error-handling
  • translations

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Able to import keystore e2e

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keystore wire up
1 participant