fix: inner step styling #8464
Merged
fix: inner step styling #8464
+27
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Error inner steps is not shown as error
https://jam.dev/c/2360f40e-496b-4539-a5be-1ad256974859
Second attempt
https://jam.dev/c/0215e46d-7a77-4342-902b-86ef1a7c6856
Third attempt after cache clear, rebuild app
https://jam.dev/c/868c4340-f7b0-4ac6-bd40-4195b2f19325
It doesn't seems to work as expected, is it?
NeOMakinG
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Edit: By comparing with another branch, I think I understood, the stepper is not throbbing anymore while errored
The error status is not related to this PR at all anyway
https://jam.dev/c/07eea805-4ce9-43ad-a90c-58159fc8adfd
I feel confortable approving this one, thanks @0xApotheosis
|
Correct! Sorry, my testing instructions could have been clearer ser @NeOMakinG - ty 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression from #8437 that broke the
innerStepStepper styling.Issue (if applicable)
N/A, fixes regression.
Risk
Small
None
Testing
Engineering
With the
REACT_APP_FEATURE_NEW_TRADE_FLOWflag enabled:Success and failure inner step indicators should be small and non-throbbing again.
Operations
Screenshots (if applicable)
See above.