Add support for Application Integration Types and Interaction Context Types #269
Conversation
EinTim23
changed the title
There was a problem hiding this comment.
Mainly looks good, just need to run Rubocop and re-locate that hash map to lib/discordrb/data/interaction.rb.
lib/discordrb.rb
Outdated
| @@ -35,6 +35,18 @@ module Discordrb | |||
| direct_message_typing: 1 << 14 | |||
| }.freeze | |||
|
|
|||
|
|
|||
| COMMAND_CONTEXTS = { | |||
There was a problem hiding this comment.
Looks good for the most part, but it may be better to have these two hash maps defined in lib/discordrb/data/interaction.rb
|
Should be resolved now, im not entirely sure about the last two offenses, as I never touched those files and there seem to be merge conflicts as contexts are apparently partially implemented by now. |
Thanks so far! Those Rubocop warnings have been fixed in master. If you want you can re-base the branch and still include integration types even though contexts have already been added. 🙂 Oh, and I meant to mention this originally, but could you document the integration types field as well, if it’s not too much trouble? Something along the lines of:
|
|
Alright, I rebased to the current commit on main. I couldn't really figure out where I'm supposed to document the parameter tho. |
Oh, Nevermind. I think it’s fine without the docs. Thanks! |
Summary
Add support for Application Integration Types and Interaction Context Types to allow registration of commands for chats outside guilds and the bots direct messages