💥 Bump redis to v4
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we already making in breaking maybe it is good time to rewrite it to typescript and use normal classes? |
|
@dawidreedsy feels way out of scope of this change |
|
Cannot work out why the coverage is failing here :/ Can repro locally, too, but I've not touched anything to do with the coverage machinery... |
|
Okay. Coverage fixed. Got caught out by the fact that |
|
Excellent! Thanks for doing this. |
Fixes #19 This is a **BREAKING** change that upgrades the underlying `redis` client to v4, which had so many [breaking changes][1], that it's infeasible to maintain backwards-compatibility with v3. If consumers need to use v3, they are advised to pin their version of `sharedb-redis-pubsub` to v4. This change adapts to the breakages: - wrap the returned `Promise`s in callbacks - actively connect the `client`, which no longer auto-connects - move the `message` event handler into the subscription callback - adapt to the new call signature of `client.eval()` [1]: https://github.com/redis/node-redis/blob/HEAD/docs/v3-to-v4.md
ericyhwang
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19
This is a BREAKING change that upgrades the underlying
redisclient to v4, which had so many breaking changes, that it's infeasible to maintain backwards-compatibility with v3. If consumers need to use v3, they are advised to pin their version ofsharedb-redis-pubsubto v4.This change adapts to the breakages:
Promises in callbacksclient, which no longer auto-connectsmessageevent handler into the subscription callbackclient.eval()