Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Projections #154

Merged
merged 3 commits into from
Oct 2, 2017
Merged

Add documentation for Projections #154

merged 3 commits into from
Oct 2, 2017

Conversation

curran
Copy link
Contributor

@curran curran commented Jun 8, 2017

Closes #135

@coveralls
Copy link

coveralls commented Jun 8, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 96.106% when pulling 8e115bb on curran:patch-7 into 2384145 on share:master.

@curran curran mentioned this pull request Jun 15, 2017
Closed
@coveralls
Copy link

coveralls commented Jun 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 96.106% when pulling 603a77e on curran:patch-7 into 2384145 on share:master.

@curran
Copy link
Contributor Author

curran commented Jun 19, 2017

Related discussions in #143

@curran
Copy link
Contributor Author

curran commented Jun 30, 2017

@nateps @rkstedman @avital This PR is ready for review.

I'm curious, are there any other maintainers who can review and merge PRs?

@curran
Copy link
Contributor Author

curran commented Jul 19, 2017

Review delay possibly related to #163

@coveralls
Copy link

coveralls commented Aug 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 96.106% when pulling f8741f3 on curran:patch-7 into 2384145 on share:master.

@curran
Copy link
Contributor Author

curran commented Aug 1, 2017

@nateps @rkstedman @zag2art Any chance of reviewing/commenting on this PR? It should be quick to review and merge, it's only documentation changes.

@curran
Copy link
Contributor Author

curran commented Sep 14, 2017

@nateps Kindly requesting review and merge of this small PR that changes documentation only. Thanks!

@curran
Copy link
Contributor Author

curran commented Sep 15, 2017

@rkstedman Thank you for merging the other PR. Is this PR controversial? Anything here that needs to change? Thank you.

@curran
Copy link
Contributor Author

curran commented Oct 2, 2017

@nateps @nornagon This PR is ready for review/merge. I'd love to hear any feedback, or reason for hesitation in merging this. Thank you.

@josephg josephg merged commit c0e2fee into share:master Oct 2, 2017
@josephg
Copy link
Member

josephg commented Oct 2, 2017

Looks good, thanks!

@curran
Copy link
Contributor Author

curran commented Oct 2, 2017

@josephg Thanks a ton! It's really great to see you active here. Huge respect for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curran @coveralls @josephg