-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync ephemeral presence data #207
Open
gkubisa
wants to merge
26
commits into
share:master
Choose a base branch
from
Teamwork:sync-presence
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,097
−24
Commits on Apr 18, 2018
-
The problem was that unsubscribe re-added the doc to the connection. Now the doc is removed from the connection after unsubscribe. Additionally, we're no longer waiting for the unsubscribe response before executing the callback. It is consistent with Query, unsubscribe can't fail anyway and the subscribed state is updated synchronously on the client side.
Configuration menu - View commit details
-
Copy full SHA for 8705c4f - Browse repository at this point
Copy the full SHA 8705c4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for af84be6 - Browse repository at this point
Copy the full SHA af84be6View commit details
Commits on Apr 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 09edf92 - Browse repository at this point
Copy the full SHA 09edf92View commit details
Commits on Apr 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9121baf - Browse repository at this point
Copy the full SHA 9121bafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dbefd1 - Browse repository at this point
Copy the full SHA 4dbefd1View commit details -
I had to add the --exit flag workaround to mocha.opts to make it exit when tests are done. A better long-term solution would be to ensure that nothing keeps node running after all tests are done, see https://boneskull.com/mocha-v4-nears-release/#mochawontforceexit.
Configuration menu - View commit details
-
Copy full SHA for 2ef8181 - Browse repository at this point
Copy the full SHA 2ef8181View commit details -
The problem was that unsubscribe re-added the doc to the connection. Now the doc is removed from the connection after unsubscribe. Additionally, we're no longer waiting for the unsubscribe response before executing the callback. It is consistent with Query, unsubscribe can't fail anyway and the subscribed state is updated synchronously on the client side.
Configuration menu - View commit details
-
Copy full SHA for 6b687db - Browse repository at this point
Copy the full SHA 6b687dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1489e36 - Browse repository at this point
Copy the full SHA 1489e36View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4499a5 - Browse repository at this point
Copy the full SHA a4499a5View commit details
Commits on Apr 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 33c7264 - Browse repository at this point
Copy the full SHA 33c7264View commit details
Commits on Apr 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 8ff4b33 - Browse repository at this point
Copy the full SHA 8ff4b33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ff380d - Browse repository at this point
Copy the full SHA 0ff380dView commit details
Commits on May 1, 2018
-
Configuration menu - View commit details
-
Copy full SHA for d67dd6a - Browse repository at this point
Copy the full SHA d67dd6aView commit details
Commits on May 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e8ec215 - Browse repository at this point
Copy the full SHA e8ec215View commit details
Commits on Jun 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9c291b2 - Browse repository at this point
Copy the full SHA 9c291b2View commit details
Commits on Jun 11, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c15448f - Browse repository at this point
Copy the full SHA c15448fView commit details
Commits on Jun 13, 2018
-
The issue could not cause problems in practice because ot-json0 does not support presence.
Configuration menu - View commit details
-
Copy full SHA for 173bf3a - Browse repository at this point
Copy the full SHA 173bf3aView commit details
Commits on Jun 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 054d34d - Browse repository at this point
Copy the full SHA 054d34dView commit details
Commits on Jul 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 15cdd1d - Browse repository at this point
Copy the full SHA 15cdd1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cfca37f - Browse repository at this point
Copy the full SHA cfca37fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e009d1 - Browse repository at this point
Copy the full SHA 5e009d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 642ded6 - Browse repository at this point
Copy the full SHA 642ded6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56b726b - Browse repository at this point
Copy the full SHA 56b726bView commit details
Commits on Jul 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 762496a - Browse repository at this point
Copy the full SHA 762496aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4c5e6d - Browse repository at this point
Copy the full SHA e4c5e6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 428c46a - Browse repository at this point
Copy the full SHA 428c46aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.