Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When done pass the callback() instead of next(). #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

When done pass the callback() instead of next(). #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/backend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ Backend.prototype.trigger = function(action, agent, request, callback) {
if (err) return callback(err);
var fn = fns.shift();
if (!fn) return callback();
fn(request, next);
fn(request, callback);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure this is correct. For starters, the tests don't pass.

Secondly, I think you'll find that passing callback like this will only ever call the first registered middleware, since we need to recursively call next() to keep pulling middlewares off the stack.

Can you build a test case that fails without this change?

};
next();
};
Expand Down