fix: only import webpack types (#297)

* remove webpack import * chore: rename _loaderContext --------- Co-authored-by: Andrew Powell <[email protected]> Co-authored-by: shellscape <[email protected]>
shellscape · Jun 19, 2023 · 64faade · 64faade
1 parent 9a39d31
commit 64faade
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/hooks.ts b/src/hooks.ts
@@ -170,14 +170,15 @@ interface LegacyModule extends Module {
   userRequest?: any;
 }
 
+
 const normalModuleLoaderHook = (
   { moduleAssets }: { moduleAssets: Record<any, any> },
-  loaderContext: LoaderContext<any>,
+  context: unknown,
   module: LegacyModule
 ) => {
+  const loaderContext = context as LoaderContext<any>;
   const { emitFile } = loaderContext;
 
-  // eslint-disable-next-line no-param-reassign
   loaderContext.emitFile = (file: string, content: string, sourceMap: any) => {
     if (module.userRequest && !moduleAssets[file]) {
       Object.assign(moduleAssets, { [file]: join(dirname(file), basename(module.userRequest)) });

diff --git a/src/index.ts b/src/index.ts
@@ -1,10 +1,7 @@
 import { relative, resolve } from 'path';
 
 import { SyncHook } from 'tapable';
-import { Compiler, WebpackPluginInstance, Compilation } from 'webpack';
-// @ts-ignore
-import NormalModule from 'webpack/lib/NormalModule';
-
+import type { Compiler, WebpackPluginInstance, Compilation } from 'webpack';
 import { FileDescriptor } from './helpers';
 import { beforeRunHook, emitHook, getCompilerHooks, normalModuleLoaderHook } from './hooks';
 
@@ -71,6 +68,7 @@ class WebpackManifestPlugin implements WebpackPluginInstance {
   }
 
   apply(compiler: Compiler) {
+    const { NormalModule } = compiler.webpack;
     const moduleAssets = {};
     const manifestFileName = resolve(compiler.options.output?.path || './', this.options.fileName);
     const manifestAssetId = relative(compiler.options.output?.path || './', manifestFileName);